Map Block: React 19 compatibility - converting defaultProps usage on MapkitComponent

[coder-karen]

Partial fix to #38271

Proposed changes:

• This PR converts the defaultProps within the MapkitComponent to be default parameters passed in to the component, to prevent issues related to the deprecation of defaultProps in React 19.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

#38271

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

• Test that the Map block continues to work as expected - add the Map block on a post or page, check the editor and front-end, check there are no console errors.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/defaultProps-usage-react-19 branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/defaultProps-usage-react-19
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for August 6, 2024 (scheduled code freeze on August 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[fgiannar]

Self-hosted
I tested using the provided instructions and it works as expected!

I created a post with a Map block and made sure to set all the corresponding block settings.

I then switched to this branch and ensured nothing had changed on both the post page and when editing the post.

I then created another post with a map and changed all the Map block settings in the editor.

It worked as expected and all my changes were also reflected in the corresponding post's page.

No relevant errors in the web console as well.

Simple
Though it works as expected overall, in some cases (could not consistently reproduce) I could not see the map block editor, when clicking on the corresponding Map block. Is this something you can also reproduce perhaps?

[coder-karen]

Thanks for testing!

Though it works as expected overall, in some cases (could not consistently reproduce) I could not see the map block editor, when clicking on the corresponding Map block. Is this something you can also reproduce perhaps?

Yes, it was, but it was the same without the changes from this PR. I went to create an issue earlier (if I'm understanding that your issue was the same as mine), but there is one already which I added to the Vulcan backlog: #31870

I noticed that issue on Simple and Atomic, I couldn't reproduce on self-hosted.

[fgiannar]

Yes, it was, but it was the same without the changes from this PR. I went to create an issue earlier (if I'm understanding that your issue was the same as mine), but there is one already which I added to the Vulcan backlog: #31870

Excellent 👍 Approving then 🚢