Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP Super cache: make sure the debug log viewer isn't deleted by garbage collection #38276

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

donnchawp
Copy link
Contributor

The debug log viewer may be deleted by garbage collection if the file is older than the garbage collection TTL. The only way to fix it is by deleting the log from the Debug log page.
This PR recreates the viewer if missing, or touches it so it's modification time is updated when garbage collection is run, so it's always seen as a new file.

Fixes #32626

Proposed changes:

  • In wp_cache_phase2_clean_expired() recreate or touch the log viewer php script so it's always new and won't be deleted by garbage collection.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Set your garbage collection timeout to 90 seconds, and GC timer to 60 seconds.
  • Enable debugging on the Debug page and load the debug viewer.
  • Wait a few minutes.
  • Try to reload the debug viewer page. Make sure that garbage collection has run more than 90 seconds after debugging was enabled. Look for "Cache garbage collection." in the logs.
@donnchawp donnchawp added [Status] Needs Team Review [Plugin] Super Cache A fast caching plugin for WordPress. labels Jul 10, 2024
@donnchawp donnchawp requested a review from a team July 10, 2024 10:07
@donnchawp donnchawp self-assigned this Jul 10, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Super Cache plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Member

@dilirity dilirity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dilirity dilirity merged commit bf25dce into trunk Jul 10, 2024
55 checks passed
@dilirity dilirity deleted the super-cache/fix/log-view-deleted branch July 10, 2024 10:24
@github-actions github-actions bot added this to the super-cache/1.12.2 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Super Cache A fast caching plugin for WordPress.
2 participants