Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MU WPCOM: Port the a8c-posts-list block from ETK #38279

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Jul 10, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/8036, https://github.com/Automattic/dotcom-forge/issues/8032

Proposed changes:

  • Port the a8c-posts-list block from ETK. Note that the a8c-posts-list block is available only when it's already in the page/post, and we are not allowing people to insert this block from the editor for the new page/post. As a result, this feature is just for the backward compatibility.
Editor Editor (Selected) Frontend
image image image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply changes to your site
  • Go to the editor
  • Switch to Code Editor
  • Enter the following code
    <!-- wp:a8c/posts-list /-->
    
  • Switch back to Visual Editor
  • Save changes because the block is registered only when it's saved in the post
  • Refresh the page
  • Make sure the block is rendered correctly
  • Preview your changes
  • Make sure the block is rendered correctly on frontend
@arthur791004 arthur791004 self-assigned this Jul 10, 2024
Copy link
Contributor

github-actions bot commented Jul 10, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the mu-wpcom/a8c-posts-list branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin mu-wpcom/a8c-posts-list
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
Copy link
Contributor

github-actions bot commented Jul 10, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Wpcomsh plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 10, 2024
@arthur791004 arthur791004 force-pushed the mu-wpcom/a8c-posts-list branch 4 times, most recently from 2bdac58 to d4f3ce2 Compare July 11, 2024 05:29
@arthur791004 arthur791004 added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 11, 2024
@arthur791004 arthur791004 requested a review from a team July 11, 2024 05:38
@arthur791004 arthur791004 changed the title WIP MU WPCOM: Port the a8c-posts-list block from ETK Jul 11, 2024
okmttdhr
okmttdhr previously approved these changes Jul 11, 2024
Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked as expected ✅

One thing I noticed is the "Update Block" button.
Screenshot 2024-07-11 at 17 17 48

After clicking the button, it turned into something like this;
Screenshot 2024-07-11 at 17 18 22

Nothing seemed broken, but I wanted to ask if this is expected.

@arthur791004
Copy link
Contributor Author

Nothing seemed broken, but I wanted to ask if this is expected.

I think it's expected!

Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arthur791004 arthur791004 merged commit 1b7b8ad into trunk Jul 11, 2024
54 checks passed
@arthur791004 arthur791004 deleted the mu-wpcom/a8c-posts-list branch July 11, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment