-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MU WPCOM: Port MailerLite Widget #38293
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as described but I'm not sure how to display the popup either even if I used the data from Automattic/wp-calypso#42885 😞
Yes, I used that account, too, but I could not see the popup either. I'm guessing something happened to the form in the account 🐱 |
Proposed changes:
This PR migrates MailerLite Widget to jetpack-mu-wpcom.
Related to p1720664428594039/1720598146.501049-slack-CRWCHQGUB, pbxlJb-601-p2 (I'll wrap up the P2 post with the query result and this PR.), Automattic/wp-calypso#42885
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
It is tricky to test this feature since you can only use MailerLite Classic if you previously had an account with it.
account
anduuid
account
anduuid
is stored in thewidget_wpcom-mailerlite
option (e.g.,echo print_r(get_option("widget_wpcom-mailerlite"))
)