Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking: added anon parameter, timestamp, and fixed hyphen replacement. #38306

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

zinigor
Copy link
Member

@zinigor zinigor commented Jul 11, 2024

Fixes a problem with event properties not being recognized as anonymous by adding the anon parameter value.

Proposed changes:

  • Adds anon parameter value.
  • Fixes hyphen replacement to avoid rejecting events for plugins like mu-wpcom-plugin
  • Adds "miliseconds" timestamp.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'
@zinigor zinigor requested a review from a team July 11, 2024 18:42
@zinigor zinigor marked this pull request as ready for review July 11, 2024 18:43
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@zinigor zinigor enabled auto-merge (squash) July 11, 2024 18:43
tools/includes/send_tracks_event.sh Outdated Show resolved Hide resolved
tools/release-plugin.sh Outdated Show resolved Hide resolved
tools/release-plugin.sh Outdated Show resolved Hide resolved
zinigor and others added 3 commits July 11, 2024 21:56
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
@zinigor zinigor merged commit 56adcdf into trunk Jul 11, 2024
53 checks passed
@zinigor zinigor deleted the add/tracking-anon-parameter branch July 11, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants