Update/use connection notices to my jetpack connection wrapper

[CodeyGuyDylan]

Proposed changes:

• Allow useMyJetpackConnection to accept additional props that get passed to useConnection
• Replace all uses of useConnection in My Jetpack to useMyJetpackConnection

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

1. Checkout this branch via the Jetpack Beta plugin or your local dev environment
   Note: A good way to test these changes is to run it locally and log out the values returned by useMyJetpackConnection to make sure they are correct
2. Go to the following pages in My Jetpack to ensure the information looks correct as it relates to the connection

• /wp-admin/admin.php?page=my-jetpack#/add-license (might want to have an unattached license for this one)

• /wp-admin/admin.php?page=my-jetpack#/

• /wp-admin/admin.php?page=my-jetpack#/add-jetpack-ai

• /wp-admin/admin.php?page=my-jetpack#/jetpack-ai

• Check out some other interstitials as the tables and cards use the hook
• /wp-admin/admin.php?page=my-jetpack#/redeem-token
  

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/use-connection-notices-to-my-jetpack-connection-wrapper branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/use-connection-notices-to-my-jetpack-connection-wrapper
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

[robertsreberski]

We could wait with making that updates until I'll merge feature/welcome-flow that enhances the hook:

jetpack/projects/packages/my-jetpack/_inc/hooks/use-my-jetpack-connection/index.ts

Line 28 in 42731eb

const useMyJetpackConnection = ( {

As actually from all use cases, we don't have to accept all connection props, but only two:

skipUserConnection = false,
redirectUri = '',

And auto-configure the rest.

But in general this PR tests well, so I give it an approval 🟢

[CodeyGuyDylan]

We could wait with making that updates until I'll merge feature/welcome-flow that enhances the hook:

Ok ill wait until that is merged and then i'll rebase this 😄