Protect: Fix ThreatFixHeader component title

[dkmyta]

Fix

• The ThreatFixHeader component that displays for each threat in the FixAllThreatsModal is missing the title element.
• Unselecting all threats from the list in the modal, then reselecting them causes console errors and results in the threat IDs not being added back to the threatIds array to be fixed when initiated.

Proposed changes:

• Update the modals that facilitate this component to ensure that the property containing the title is accessible and used
• Disable the Fix all threats button in the modal when all threats are unselected
• Fix the handleCheckboxClick functionality to avoid console errors

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

• https://github.com/Automattic/jetpack-scan-team/issues/1271

Does this pull request change what data or activity we track or use?

• No

Testing instructions:

• Create a new Jurassic Ninja site and enable this branch of Protect using the Beta Tester plugin
• Add an upgrade and multiple fixable threats and run a scan
• Once located, connect your user and enter your credentials and click Fix all threat or within an individual threat accordion item Fix threat
• Verify that the threat title displays in either modal for each threat present
• From the Fix all threats modal ensure that you can unselect all threats, that the Fix all button becomes disabled, and that you can reselect threats (without console errors) and the Fix all buttons becomes available once again
• Ensure no regressions are introduced

Screenshots:

Single threat:

Before w/ multiple threats:

After w/ multiple threats:

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Protect plugin:

• Next scheduled release: August 6, 2024.
• Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[nateweller]

Good catch and nice fix!

[nateweller]

Using title makes sense to me, does this affect the handleIgnoreThreatClick() method above this one as well? i.e. can we potentially remove the getLabel() method entirely?

I'm not sure why the label was not displaying in the first place, since we're generating the value programmatically. Maybe an issue of not using callback/memo hooks? I'm just testing to verify that, and then I'll approve this PR 👍 👍

[dkmyta]

I've gone through this in more detail now and discovered that we don't generate the label prop for the threats list in advance of rendering this particular modal, whereas we do in others. Getting rid of the getLabel methods doesn't appear to be a logical solution either as we use that property in a variety of other location in the scan UI. Therefor, I've opted to reassess and bring in the label prop to the FixAllThreatsModal by generating the property initially directly within the useThreatsList hook, rather than the location that list is passed to.

[nateweller]

LGTM!