CRM: Fix dashboard contact graph

[gogdzl]

Fixes https://github.com/Automattic/zero-bs-crm/issues/3468

Proposed changes:

• This PR fixes the dashboard contact graph which shows wrong values in some instances.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/zero-bs-crm/issues/3468

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

• Create one contact in the last day of the month
• Change your timezone to a high enough value that would cause the day to overflow, when changing timezones
• Verify that the graph gets shifted
• Apply this PR's code to your CRM installation
• Verify that the error is gone

Alternatively just test the new code and check if the behavior is consistently the same as the previous, and that the new code looks good enough.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

[coder-karen]

Nice, thanks for working on this.

What would be the best way to change the timezone? In my case I created a contact and set the creation date for June 30th UTC+0, evening. Changed my timezone in WordPress to UTC+13 which changed the contact creation date to July 1st. The dashboard graph still shows the contact entry for June, both with and without the PR.

[gogdzl]

What would be the best way to change the timezone? In my case I created a contact and set the creation date for June 30th UTC+0, evening. Changed my timezone in WordPress to UTC+13 which changed the contact creation date to July 1st. The dashboard graph still shows the contact entry for June, both with and without the PR.

That's a great question. That should've bugged the dashboard's graph. Adjust inside your database zbsc_created so MONTH(FROM_UNIXTIME(zbsc_created)) as month returns June on your machine's timezone.

[coder-karen]

Yes that's how I adjusted the zbsc_created initially for the contact, the timestamp there (in the database, for zbsc_created) is for June 30th, unless I'm misunderstanding 🤔

[cleacos]

To test this way:

We could use the WP installation timezone configured:

$datetime_month = new DateTime( '@', $v->ts );
$datetime_month->setTimezone( new DateTimeZone('the_UTC_time_zone') );
$the_month = $datetime_month->format( 'M y' );