-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Sync: Add support for WooCommerce HPOS checksums #38320
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Backup plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Search plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Social plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Starter Plugin plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Videopress plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Migration plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Automattic For agencies client plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, tested with both HPOS and post-based store enabled, can confirm that WordPress.com does no HPOS checksums yet, and there are no warnings/fatals on the Jetpack side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing based mainly on testing - logs (when added) show what is expected - nothing else being output into logs, also no fatals.
This PR adds support for WooCommerce HPOS simple checksums and while doing that fixes the check on whether they are supported.
Proposed changes:
Automattic\Jetpack\Sync\Replicastore
: Adds support for WooCommerce HPOS checksums by adding those inchecksum_all
methodAutomattic\Jetpack\Sync\Replicastore\Table_Checksum
: Introducesenable_woocommerce_hpos_tables
method that explicitly checks for WooCommerce HPOS table Checksum support.Automattic\Jetpack\Sync\Replicastore\Table_Checksum
: Introducesjetpack_table_checksum_force_enable_woocommerce_hpos
filter to allow us to bypass the WooCommerce HPOS table support checks on WPCOMAutomattic\Jetpack\Sync\Replicastore\Table_Checksum
: Updates theis_table_enabled_callback
for HPOS tables to use the static method we introduced:enable_woocommerce_hpos_tables
Other information:
Jetpack product discussion
p9dueE-8ec-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
See D155142-code