Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce Multi-Selection with audible message #3696

Closed
afercia opened this issue Nov 28, 2017 · 1 comment
Closed

Announce Multi-Selection with audible message #3696

afercia opened this issue Nov 28, 2017 · 1 comment
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@afercia
Copy link
Contributor

afercia commented Nov 28, 2017

Reporting some first feedback from assistive technologies users, see https://make.wordpress.org/accessibility/2017/11/28/screen-reader-user-experience-with-gutenberg/

From a user:

While selecting and copying text in the blocks strange things happen. The cursor gets lost and I have to click the mouse to return into the text.

While I wasn't able to reproduce the specific issue, I'm guessing this has to do with selecting text across contiguous blocks. To reproduce:

  • add 2-3 contiguous paragraphs with some text
  • put the cursor in the middle of the first paragraph
  • using the keyboard, start selecting text for example using Shift - Right arrow
  • when the selection reaches the end of a block, the blocks multi-selection kicks in and you'll end up with two contiguous blocks selected:

screen shot 2017-11-28 at 14 38 00

Nothing of this is announced with some audible message to screen reader users, nor it is (at the moment) documented in any guide line / help.

Any kind of interaction / behavior which is not native (and thus it's not expected) should be announced with an audible message. A visual feedback is not enough for low vision or blind users.

At the very least:

  • blocks multi-selection should be well explained in a Gutenberg help guide, I'd like to see some discussion about a comprehensive guide to Gutenberg usage
  • when the multi-selection kicks in, it should be announced and should indicate the number of selected blocks; at the moment, there's only a visual indication in the "blocks" tab
  • not sure why focus is moved to the settings ellipsis button: this is a not expected behavior and should not happen; it is far better to let users find this button in the natural tab sequence after the multi selection, so I'd propose it should be placed after the multi-selection
  • the current button text "Open Settings Menu" is not so meaningful: as this control appears to contain actions that are only available with a multi-selection, it should have a meaningful text to convey this information, something like "Multi selection actions" (better wording welcome)
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Nov 28, 2017
@afercia
Copy link
Contributor Author

afercia commented Jul 16, 2018

Discussed during today's accessibility meeting, and agreed the part about "when the multi-selection kicks in, it should be announced (with an audible message)" should have high priority.

@mtias mtias changed the title Accessibility feedback: selecting / copying text across blocks is confusing Oct 3, 2018
@mtias mtias added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Oct 3, 2018
@mtias mtias changed the title Announce Multi-Selection with audile message Oct 3, 2018
@tofumatt tofumatt self-assigned this Nov 1, 2018
tofumatt added a commit that referenced this issue Nov 2, 2018
tofumatt added a commit that referenced this issue Nov 6, 2018
* feat: Add multi-block selection announcement

Fixes #3696

* chore: Add test for multi-select speak()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Task Issues or PRs that have been broken down into an individual action to take
6 participants