Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/react native colours to variables #22985

Closed
wants to merge 2 commits into from
Closed

Update/react native colours to variables #22985

wants to merge 2 commits into from

Conversation

enejb
Copy link
Contributor

@enejb enejb commented Jun 8, 2020 •
edited
Loading

Description

This PR tries to fix wordpress-mobile/gutenberg-mobile#1783
By updating the hard coded colours with sass variables.

How has this been tested?

TBD

Screenshots

Floating tool bar (Spacer bar colour):
Before:
Screen Shot 2020-06-05 at 3 20 11 PM

After: notice that the spacer bar matches the colour of the arrow.
Screen Shot 2020-06-05 at 3 19 14 PM

Types of changes

Updated of the code to use the currently supplied sass colour variables.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
@enejb enejb mentioned this pull request Jun 8, 2020
Open
2 tasks
@gziolo gziolo added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 14, 2020
@gziolo
Copy link
Member

gziolo commented Nov 28, 2020

@enejb, this PR need to be rebased. Is this refactor still valid but it was never reviewed and wasn’t land? Changes look reasonable.
@gziolo gziolo requested review from Tug and hypest November 28, 2020 06:04
@gziolo gziolo added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Nov 28, 2020
@enejb
Copy link
Contributor Author

enejb commented Nov 28, 2020 via email

@hypest hypest removed their request for review November 30, 2020 12:30
Base automatically changed from master to trunk March 1, 2021 15:43
@enejb
Copy link
Contributor Author

enejb commented Aug 3, 2022

I am closing this for now since this PR should be done a different way as part of a project where we clean up the editor colours.
@enejb enejb closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed.
2 participants
@enejb @gziolo