-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete: add position property #28611
Conversation
Size Change: +31 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
how to use this? |
94ab5a4
to
7bb55ec
Compare
Should we add a Storybook example for this? |
eae4070
to
b19c2ed
Compare
starting to deal whit this here b19c2ed |
I'm afraid this leaks the internal implementation of the autocomplete making it harder to change how it is structured in the future. Do we really need to be able to pass down all |
Thanks, Greg.
I tried to follow how the
I guess we could pass only a
It was part of a custom implementation, where the designer asked me whether was possible to move the autocomplete dropdown just below the input element. I don't wanna bothering you with the details :-)
Yeah, I think that would be great. Simpler, and clearer. |
Right, we needed that |
Nice to know.
💯
yeah, agree. Updating... |
aea3553
to
43ab167
Compare
Rebased, and handled here 43ab167290d9204df337c27e8d9761c4fab15094. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good direction. Thank you for addressing my feedback 👍🏻
b75388b
to
8eebbf9
Compare
8eebbf9
to
b1034b9
Compare
Description
The changes suggested in this PR allow setting the position to the autocomplete Popover.
How has this been tested?
You should see the autocomplete popover below to the text input component.
Screenshots
Types of changes
Checklist: