Block Bindings: avoid using local state for bound attributes #60276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -5 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
retrofox
added
[Feature] Custom Fields
retrofox
requested review from
ellatrix,
fluiddot,
dcalhoun and
tellthemachines
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Mar 29, 2024
|
After talking in a Slack conversation, we considered using the block attributes to store the bound values could bring some issues. Using a local state to store the data from the external source is okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This pull request removes the local state that stores the bound attribute values and instead relies on the block attributes object, like a regular block.
The changes to the bound attribute values are made non-persistent, to avoid adding undesired events in the editor history.
Additionally, it fixes an issue with the use of the MarkPersistent() RichText hook (props to @michalczaplinski)
Why?
Because creating an instance of a local state can negatively impact the implementation's efficiency in terms of resources, no matter how small. Additionally, it makes the implementation more unnecessarily complex.
How?
Taking advantage of the
syncDerivedUpdates()action, and fixing the MarkPersistent() issue.Testing Instructions
Testing Instructions for Keyboard
core/paragraph
core/image
Screenshots or screencast
Screen.Recording.2024-03-28.at.10.58.39.mov