Update: Show Pre Publish Panel when are are publishing a private post. #62077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +10 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Thanks for the PR! There are so many nuances with the flow that I can't be sure, but by also testing the previous flow (by deactivating GB). Changing the status to Screen.Recording.2024-05-29.at.10.16.06.AM.mov |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Switching from draft/pending to published will invoke the checks, but draft → private → published will bypass them. It’s the same for draft → private → scheduled. This could be considered an oversight, so I do think there's a case to be made that switching from an unpublished status (pending, draft) to a published status (private, scheduled, published) should invoke the checks. But I'm also curious to hear more thoughts on this, given things have been this way for so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently when you are publishing a private post it seems like we are just saving the post but the post does show up for logged in users as if it is published even though it is not visible in a lot of contexts in the front end.
Why?
We want to treat publishing a private post as if you are actually publishing the post.
How?
The Pr addresses the issue by adding the prepublish flow as well updates the button to tell the use that they are publishing the post vs just saving it.
Testing Instructions
Create a new private post. Does it tell you to save the post or publish it?
Testing Instructions for Keyboard
Create a new private post. Does it tell you to save the post or publish it?
Screenshots or screencast
Before:
trunk.mov
After:
new-pr.mov