Cover: Update min-height control. #62742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jasmussen
commented
Jun 21, 2024
| id={ inputId } | ||
| isResetValueOnUnitChange | ||
| min={ min } | ||
| onChange={ handleOnChange } | ||
| onUnitChange={ onUnitChange } | ||
| __unstableInputWidth="80px" | ||
| __unstableInputWidth="calc(50% - 4px)" |
There was a problem hiding this comment.
Those 4px make up half the 8px gap that sits between width/height in the image block. There's a better way to do this, but is it this PR? I can also just type in 120px.
There was a problem hiding this comment.
I think that 8px may be incorrect 🙈
According to #46734 the gap between columns should be 16px. This is the case in the background size inputs:
Ideally we avoid a hard-coded value, just in case the inspector width changes in the future.
There was a problem hiding this comment.
Probably, there is a difference in the gap values between the two, so in the future it will be necessary to unify the gap rules.
ToolsPanel has a gap value of 8px (Source):
On the other hand, the FocalPointPicker component has a gap value of 16px (Source):
Which one should we unify it to? I would lean towards standardizing on 8px.
By the way, width/height in the image block, grid-column: span 1 is applied:
Therefore, I think the following approach is also possible:
Details
diff --git a/packages/block-library/src/cover/edit/inspector-controls.js b/packages/block-library/src/cover/edit/inspector-controls.js
index 39dd425c62..65c32fd526 100644
--- a/packages/block-library/src/cover/edit/inspector-controls.js
+++ b/packages/block-library/src/cover/edit/inspector-controls.js
@@ -79,7 +79,6 @@ function CoverHeightInput( {
min={ min }
onChange={ handleOnChange }
onUnitChange={ onUnitChange }
- __unstableInputWidth="calc(50% - 4px)"
units={ units }
value={ computedValue }
size="__unstable-large"
@@ -314,6 +313,7 @@ export default function CoverInspectorControls( {
} ) }
isShownByDefault
panelId={ clientId }
+ style={ { gridColumn: 'span 1' } }
>
<CoverHeightInput
value={There was a problem hiding this comment.
I think the intended value is 16px, and there's a discrepancy here. I'm happy to take a stab at trying to unify it here.
I have a feeling this might be best done separately, so what do you think I should set as a value for this one in the mean time?
There was a problem hiding this comment.
I noticed that there is a style for a single column of the dimension panel:
Since the min-height control is also part of the dimension panel, we should be able to make the following changes to this PR:
diff --git a/packages/block-library/src/cover/edit/inspector-controls.js b/packages/block-library/src/cover/edit/inspector-controls.js
index 39dd425c62..80110d5158 100644
--- a/packages/block-library/src/cover/edit/inspector-controls.js
+++ b/packages/block-library/src/cover/edit/inspector-controls.js
@@ -79,7 +79,6 @@ function CoverHeightInput( {
min={ min }
onChange={ handleOnChange }
onUnitChange={ onUnitChange }
- __unstableInputWidth="calc(50% - 4px)"
units={ units }
value={ computedValue }
size="__unstable-large"
@@ -300,6 +299,7 @@ export default function CoverInspectorControls( {
) }
<InspectorControls group="dimensions">
<ToolsPanelItem
+ className="single-column"
hasValue={ () => !! minHeight }
label={ __( 'Minimum height' ) }
onDeselect={ () =>The width value is not hard-coded, so when the ToolsPanel gap changes from 8px to 16px, we don't need to update the min-height control's style.
There was a problem hiding this comment.
Nice, that works!
You'll see that it doesn't line up with the border controls below, but as you surfaced with width/height and left/top, that's a separate thing to fix!
|
Size Change: +131 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Jun 24, 2024
There was a problem hiding this comment.
LGTM!
I think E2E tests will fail, but that's another issue in the core, see the link below.
WordPress/wordpress-develop#6875 (comment)
https://wordpress.slack.com/archives/C02QB2JS7/p1719209877579299
I'm not sure whether to force merge this PR or not, but let's wait a bit.
t-hamano
approved these changes
Jun 24, 2024
|
Thank you for the review and the context. I think the ship has sailed for this to be a backport, though, so there's no rush on force merging. |
|
@jasmussen I had created PR to implement range slider for height control of cover block. Is this still relevant? please let me know. |
|
@akasunil Sorry, I missed that. I think that's still relevant, yes. I think if you can include the title change from this PR, perhaps I can close mine in favor of yours? |
|
Yes, I have updated title too. Screenshot is old one, ill update it. |
|
Closing this one in favor of #62509. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The Cover block has a min-height control using legacy input size, and a label, "Minimum height of cover", redundant since it's only ever showin inside the inspector for the cover block:
This PR updates the input to be the new default size, and larger unit selector, and changes the label to read "Minimum height":
For comparison, here's the image width/height controls:
Testing Instructions
Insert a cover block, test the min-height inspector control.