Improve usage and documentation of the landmark region labels. #7940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
approved these changes
Jul 13, 2018
There was a problem hiding this comment.
Looks good to me 👍 Thank you for this improvement.
On chrome, the Gutenberg landmark region navigator (control + ´/< ) is not working correctly now in my tests, but that regression was not caused by this PR.
Edited: it turns it was just my browser being weird after a restart things look fine.
This was referenced Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to improve the aria-labels used for the navigable region landmarks and clarify their usage in the related README. Please refer to the related issue #7938 for more details.
Worth reminding these labels are not visible and screen readers will automatically add the word "region" so they will announce:
Also, adds some translators comments and clarifies the aria-label usage in the README.
Fixes #7938
How has this been tested?
npm test