-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install parent-theme-2021, which is required by translation events #7
Conversation
a17328b
to
5bb3a49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! For some reason the original theme activation was wrong, I committed a little fix.
@@ -249,7 +249,7 @@ fi | |||
# Enable the rosetta theme | |||
# To see the available themes, execute: npm run wp-env run cli wp theme list | |||
print_header "Enabling the wporg theme" | |||
$WP_CLI_PREFIX wp theme activate pub $WP_CLI_SUFFIX | |||
$WP_CLI_PREFIX wp theme activate pub/wporg $WP_CLI_SUFFIX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, then this is a difference between LAMP and wp-env. Maybe we can get them the same via changing the mapping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub/wporg
is closer to what the real WordPress.org structure is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that makes sense, I'll look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed the necessary change, could you try if it still works in wp-env?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized I had already merged it on Github, so I pushed the changes to the branch and re-merged it locally. So the change is already in main, committed via af0f924
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, thanks!
This PR makes it so that the
pull_repos.sh
script also pulls the wporg-parent-2021 theme, and theprovision.sh
script links in underwp-content/themes
.This theme is required by translation events. It is already present on the production environment.