Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landing page: Headings now have dark thick underlines #98

Closed
jasmussen opened this issue Jun 18, 2024 · 4 comments
Closed

Landing page: Headings now have dark thick underlines #98

jasmussen opened this issue Jun 18, 2024 · 4 comments
Assignees
@ryelle

Comments

@jasmussen
Copy link

At launch, the Documentation section had dark headings with no underlines. Some time recently, rather thick dark underlines were added:

Image

Is this an unintentional regression?

If it's because the links must be underlined, we should unlink the headings and instead add a separate "See all" hyperlink.
@ndiego
Copy link
Member

ndiego commented Jun 18, 2024

This may be due to CSS specificity changes in Gutenberg 18.5 and soon to be in WordPress 6.6. We can into similar link-related issues here.
@ryelle
Copy link
Collaborator

ryelle commented Jun 18, 2024

These have always had underlines (see the screenshots on #71), but you're right that the underline changed. It does seem related to the GB update.
@ryelle ryelle self-assigned this Jun 18, 2024
ryelle added a commit to WordPress/wporg-parent-2021 that referenced this issue Jun 18, 2024
@ryelle
Styles: Move link style to theme.json
3b02a3b 
This fixes the interaction of link styles applied by other elements in theme.json, by ensuring the base styles are set in the same way.
Additionally, this increases the specificity of the text-decoration longhand properties, so that they apply after the shorthand `text-decoration` from theme.json.

Fixes #143, WordPress/wporg-documentation-2022#98
@ryelle
Copy link
Collaborator

ryelle commented Jun 18, 2024

I've fixed the regression, and these are back to having the small underline:

Screenshot 2024-06-18 at 6 05 38 PM
@ryelle ryelle closed this as completed Jun 18, 2024
@jasmussen
Copy link
Author

Thanks for fixing the regression!
DanyloKubyshkin added a commit to DanyloKubyshkin/wordpress-org that referenced this issue Jul 12, 2024
@DanyloKubyshkin
Styles: Move link style to theme.json
193388c 
This fixes the interaction of link styles applied by other elements in theme.json, by ensuring the base styles are set in the same way.
Additionally, this increases the specificity of the text-decoration longhand properties, so that they apply after the shorthand `text-decoration` from theme.json.

Fixes #143, WordPress/wporg-documentation-2022#98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@ryelle @jasmussen @ndiego