Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] The response body is not recognised as JSON in query WebHook config endpoints #4286

Closed
2 tasks done
Pil0tXia opened this issue Jul 26, 2023 · 0 comments · Fixed by #4287
Closed
2 tasks done

[Bug] The response body is not recognised as JSON in query WebHook config endpoints #4286

Pil0tXia opened this issue Jul 26, 2023 · 0 comments · Fixed by #4287
Labels
bug Something isn't working

Comments

@Pil0tXia
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Windows

EventMesh version

master

What happened

The response body is not recognised as JSON in Postman, and the Content-Type header missing:

image

image

How to reproduce

That's because NetUtils.sendSuccessResponseHeaders(httpExchange); is in front of httpExchange.getResponseHeaders().add(CONTENT_TYPE, APPLICATION_JSON); and headers are sent out before they are set correctly.

Debug logs

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Pil0tXia Pil0tXia added the bug Something isn't working label Jul 26, 2023
@Pil0tXia Pil0tXia changed the title [Bug] The response body is not recognised as JSON in admin endpoints Jul 26, 2023
@Pil0tXia Pil0tXia changed the title [Bug] The response body is not recognised as JSON in query webhok config endpoints Jul 26, 2023
@Pil0tXia Pil0tXia mentioned this issue Jul 26, 2023
Merged
xwm1992 pushed a commit that referenced this issue Jul 27, 2023
@Pil0tXia
[ISSUE #4286] Fix response body is not recognised as JSON in query We…
6b8e5e6 
…bHook config endpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
1 participant
@Pil0tXia