Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Promethus source connector #4415

Closed
1 of 3 tasks
qqeasonchen opened this issue Aug 29, 2023 · 6 comments · Fixed by #4493
Closed
1 of 3 tasks

[Feature] Add Promethus source connector #4415

qqeasonchen opened this issue Aug 29, 2023 · 6 comments · Fixed by #4493
Assignees
Labels

Comments

@qqeasonchen
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Feature Request

Add Promethus source connector

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@willimpo
Copy link
Contributor

@qqeasonchen please assign to me

@willimpo
Copy link
Contributor

willimpo commented Oct 10, 2023

In the prometheus source connector, I try to call prometheus api:/api/v1/query_range to obtain monitoring data as event. Is this appropriate? Please give me some advice.
@xwm1992 @mxsm

https://prometheus.io/docs/prometheus/latest/querying/api/

@Pil0tXia
Copy link
Member

@willimpo SDK is preferred and OpenAPI is acceptable. You may warp prometheus response into an object instead of json string for a better readability.

@xwm1992
Copy link
Contributor

xwm1992 commented Oct 10, 2023

In the prometheus source connector, I try to call prometheus api:/api/v1/query_range to obtain monitoring data as event. Is this appropriate? Please give me some advice. @xwm1992 @mxsm

https://prometheus.io/docs/prometheus/latest/querying/api/

Using HTTP API is OK, it is necessary to pay attention to the indicator data type of the query, the return format, and the design of the query parameters.

@willimpo
Copy link
Contributor

In the prometheus source connector, I try to call prometheus api:/api/v1/query_range to obtain monitoring data as event. Is this appropriate? Please give me some advice. @xwm1992 @mxsm
https://prometheus.io/docs/prometheus/latest/querying/api/

Using HTTP API is OK, it is necessary to pay attention to the indicator data type of the query, the return format, and the design of the query parameters.

OK,thanks

@willimpo
Copy link
Contributor

@willimpo SDK is preferred and OpenAPI is acceptable. You may warp prometheus response into an object instead of json string for a better readability.

OK I'll try

xwm1992 pushed a commit that referenced this issue Oct 22, 2023
* Add Promethus source connector

* Add Promethus source connector

* Add Promethus source connector

* Add Promethus source connector

* Add Promethus source connector

* Add Promethus source connector

* Add Promethus source connector

* Add Promethus source connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants