Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] when wechat send message api response errcode is not zero, the wechat sink connector does not throw IllegalAccessException #4602

Closed
3 tasks done
wizardzhang opened this issue Dec 5, 2023 · 1 comment · Fixed by #4627
Closed
3 tasks done

[Bug] when wechat send message api response errcode is not zero, the wechat sink connector does not throw IllegalAccessException #4602

wizardzhang opened this issue Dec 5, 2023 · 1 comment · Fixed by #4627
Labels
bug Something isn't working

Comments

@wizardzhang
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Windows

EventMesh version

master

What happened

when i use wechat-sink-connector send message test some abnormal case, like this
image
when response errcode is not zero , it should throw IllegalAccessException
image
actually it does not, because the class TemplateMessageResponse.calss filed errocode is wrong, not match the wecaht response json errcode
image
sorry for missing abnormal case in unit test, i will add abnormal case in unit test and fix the bug

How to reproduce

i use wechat-sink-connector send message test some abnormal case, make the wechat server response errcode is not zero

Debug logs

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@wizardzhang wizardzhang added the bug Something isn't working label Dec 5, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Welcome to the Apache EventMesh community!!
We are glad that you are contributing by opening this issue. :D

Please make sure to include all the relevant context.
We will be here shortly.

If you are interested in contributing to our project, please let us know!
You can check out our contributing guide on contributing to EventMesh.

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives
@wizardzhang wizardzhang changed the title [Bug] when wechat send message api responses errcode is not zero, the wechat sink connector dont throw IllegalAccessException Dec 5, 2023
This was referenced Dec 5, 2023
Closed
Merged
@mxsm mxsm closed this as completed in #4627 Dec 8, 2023
mxsm pushed a commit that referenced this issue Dec 8, 2023
@wizardzhang
[ISSUE #4602] when wechat send message api response errcode is not ze…
ee9ee4c 
…ro, the wechat sink connector does not throw IllegalAccessException (#4627)

* fix issue#4602

* change README.md file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
1 participant
@wizardzhang