NIFI-7680 Added convenience methods for creating XML DocumentBuilder … #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instances. Added unit tests.
mattyb149
reviewed
Jul 28, 2020
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/NotificationServiceManager.java
Outdated
Show resolved
Hide resolved
…erviceManager to avoid nifi-bootstrap dependency on nifi-security-utils. Explicitly added commons-lang3 to lib/bootstrap/ directory in nifi-assembly.
Added explicit dependencies where necessary.
|
+1 LGTM, ran a few different scenarios with components that do XML processing. Thanks for the improvement! Merging to master |
ets
pushed a commit
to ets/nifi
that referenced
this pull request
Oct 2, 2020
…instances. Added unit tests. NIFI-7680 Duplicated DocumentBuilder creation method in NotificationServiceManager to avoid nifi-bootstrap dependency on nifi-security-utils. Explicitly added commons-lang3 to lib/bootstrap/ directory in nifi-assembly. NIFI-7680 Reverted unnecessary dependency changes. Added explicit dependencies where necessary. Signed-off-by: Matthew Burgess <mattyb149@apache.org> This closes apache#4436
driesva
pushed a commit
to driesva/nifi
that referenced
this pull request
Mar 19, 2021
…instances. Added unit tests. NIFI-7680 Duplicated DocumentBuilder creation method in NotificationServiceManager to avoid nifi-bootstrap dependency on nifi-security-utils. Explicitly added commons-lang3 to lib/bootstrap/ directory in nifi-assembly. NIFI-7680 Reverted unnecessary dependency changes. Added explicit dependencies where necessary. Signed-off-by: Matthew Burgess <mattyb149@apache.org> This closes apache#4436
13 tasks
krisztina-zsihovszki
pushed a commit
to krisztina-zsihovszki/nifi
that referenced
this pull request
Jun 28, 2022
…instances. Added unit tests. NIFI-7680 Duplicated DocumentBuilder creation method in NotificationServiceManager to avoid nifi-bootstrap dependency on nifi-security-utils. Explicitly added commons-lang3 to lib/bootstrap/ directory in nifi-assembly. NIFI-7680 Reverted unnecessary dependency changes. Added explicit dependencies where necessary. Signed-off-by: Matthew Burgess <mattyb149@apache.org> This closes apache#4436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…instances.
Added unit tests.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Makes creating
DocumentBuilderinstances easier.In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
main)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.