-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-12403 Improve Jolt UI Parameter Processing #8060
Conversation
reviewing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor change to keep consistent with how we define string in JavaScript (single quotes). Other than that, this works well.
$scope.disconnectedNodeAcknowledged = params.disconnectedNodeAcknowledged === "true"; | ||
$scope.editable = params.editable === "true"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$scope.disconnectedNodeAcknowledged = params.disconnectedNodeAcknowledged === "true"; | |
$scope.editable = params.editable === "true"; | |
$scope.disconnectedNodeAcknowledged = params.disconnectedNodeAcknowledged === 'true'; | |
$scope.editable = params.editable === 'true'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I pushed the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @exceptionfactory !
* Improved Jolt UI Parameter Processing * Changed double quotes to single quotes per review This closes #8060
Summary
NIFI-12403 Improves the
JoltTransformJSON
Processor custom user interface parameter initialization parsing. The JavaScript controller sets Boolean properties based on initial state parameters, which are passed as strings. Adjusting the processing to use a simple string comparison avoids unnecessary additional parsing.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation