MAPIType.isFixedLength: not true in case of length > 8 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h properties are always stored as 8 bytes (zero-padded if length < 8)
|
Can one of the admins verify this patch? |
|
Patch applied via r1857708, thank you for bringing this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAPIType.isFixedLength: not true in case of length > 8 as fixed length properties are always stored as 8 bytes (zero-padded if length < 8) and cannot exceed 8 bytes.Writing e.g.
MAPITypeCLS_IDwhich has length 16 would fail otherwise.(Defined here:
poi/src/scratchpad/src/org/apache/poi/hsmf/datatypes/Types.java
Line 69 in f509d1d