-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XWPFPicture: easy access to width and depth #150
Conversation
Can one of the admins verify this patch? |
} | ||
|
||
/** | ||
* Returns the width of the picture (in EMU). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
width
was copied from above.
Most of the other API use Units.toPoints()
to convert out of EMU to more human understandable points.
I've just added a test for the new methods. Is this enough for merging? |
@pjfanning @Alain-Bearez is this OK to merge? |
merged using https://svn.apache.org/repos/asf/poi/trunk@1863434 |
…hibaut Cuvelier. This closes #150 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863434 13f79535-47bb-0310-9956-ffa450edef68
…hibaut Cuvelier. This closes apache#150 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1863434 13f79535-47bb-0310-9956-ffa450edef68
I suppose adding a test case wouldn't hurt (something like calling XWPFRun.addPicture then calling these two new methods).
(BTW, would a pull request to add an overload to XWPFRun.addPicture be accepted? It would be to compute the width and depth from the input file, using javax.ImageIO -- an acceptable dependency or not?)