XWPFParagraph: direct control over keepNext. #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
pjfanning
reviewed
Jun 5, 2019
| * Indicates whether this paragraph should be kept on the same page as the next one. | ||
| */ | ||
| public boolean isKeepNext() { | ||
| if (getCTP() != null && getCTP().getPPr() != null) { |
There was a problem hiding this comment.
does this compile? seems to me, this has no return if the if-condition fails
There was a problem hiding this comment.
I've corrected this and added a test. Better?
|
this is merged - #156 had the same code and I merged it there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.