Fix Bug in XSSFTable.setCellReferences when table is single cell #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
asfgit
pushed a commit
that referenced
this pull request
Dec 11, 2019
…gle cell. Thanks to Travis Russell. This closes #164 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871185 13f79535-47bb-0310-9956-ffa450edef68
Alain-Bearez
pushed a commit
to cuali/poi
that referenced
this pull request
Dec 12, 2019
…gle cell. Thanks to Travis Russell. This closes apache#164 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871184 13f79535-47bb-0310-9956-ffa450edef68
Alain-Bearez
pushed a commit
to cuali/poi
that referenced
this pull request
Dec 12, 2019
…gle cell. Thanks to Travis Russell. This closes apache#164 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871185 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
XSSFTable.setCellReferencesthrows anArrayIndexOutOfBoundsExceptionin the case when the table is only one cell.XSSFTable.setCellReferencessets the table'sstartCellReferenceandendCellReference.It fails because it expects a colon in the table reference, but in the one cell case there is no colon. In this case, it is simply a single cell, e.g.,
A2. This causes the exception to be thrown when setting theendCellReference, as the code expects a second part of the table reference.This fix is to check the parts after we split the reference. If there is only one part, set the end reference to the same value as the start reference.