New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XWPFNumbering.addAbstractNum will definitely throw an exception #171

Closed

Sayi wants to merge 1 commit into apache:trunk from Sayi:numbering-patch

Member

Sayi commented Mar 23, 2020 •

edited

Loading

XWPFNumbering.addAbstractNum code is an if branch. There are two points to note:

When abstractNum.getAbstractNum () is not null, you must ensure that AbstractNumId has a value, so in order for users to find the correct AbstractNumId value, two getter methods are exposed, of course, the list cannot be modified.
When abstractNum.getAbstractNum () is null, an exception will be thrown when cascading the method of abstractNum.getAbstractNum (), so you need to set the attribute CtAbstractNum of the abstractNum.

PS: For the first point, we can also assert in the XWPFNumbering.addAbstractNum that AbstractNumId is not null, fail fast.


          XWPFNumbering.addAbstractNum will definitely throw an exception

107782b

Contributor

Alain-Bearez commented Apr 2, 2020

applied by commit r1875747

this PR can be closed

Sayi closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment