Improve perfomance of cell evaluation #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Dec 10, 2020
| @@ -49,6 +48,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more | |||
| // use Boolean to have a tri-state for on/off/undefined | |||
| private Boolean _hidden = UNDEFINED; | |||
| private Boolean _collapsed = UNDEFINED; | |||
| private int number; | |||
There was a problem hiding this comment.
could you call this rowNumber?
| @@ -437,6 +437,10 @@ public SXSSFSheet getSheet() | |||
| { | |||
| return _sheet; | |||
| } | |||
|
|
|||
| public void setNumber(int rownum) { | |||
There was a problem hiding this comment.
does this need to be public - can't it be package-private? -- can it be called setRowNum? To match the name of getRowNum.
|
Sure. Updated the patch to meet existing code style. |
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SXSSFRow.getRowNum()method is heavily used from various parts of the code (in particular, from the cell evaluation method). Current implementation of the method is using iterating over sheet rows to find the row number. This approach is ineffective for large sheets. The proposed patch stores the row number directly in the row object to improve method performance.