Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDGF: Add support for PolyLineTo geometry type #604

Closed
wants to merge 1 commit into from

Conversation

komarovd95
Copy link

Implementation of POLYLINE geometry using LineTo path segments.

The code itself runs in production for a relatively long time and tested multiple times. I also used this file to test its working.

@pjfanning
Copy link
Contributor

Can I ask you to test with Java 8. Neither this nor your previous PR compile with Java 8.

Issues like

/Users/pj.fanning/svn/poi/poi-ooxml/src/test/java/org/apache/poi/xdgf/usermodel/section/geometry/TestPolylineTo.java:100: error: cannot infer type arguments for java.util.HashMap<K,V>
                new HashMap<>() {{

I will fix this locally so you don't need to fix it here - but if you submit more PRs, can you ensure that they compile?

@asfgit asfgit closed this in d0a5b62 Mar 6, 2024
@komarovd95
Copy link
Author

Can I ask you to test with Java 8. Neither this nor your previous PR compile with Java 8.

Issues like

/Users/pj.fanning/svn/poi/poi-ooxml/src/test/java/org/apache/poi/xdgf/usermodel/section/geometry/TestPolylineTo.java:100: error: cannot infer type arguments for java.util.HashMap<K,V>
                new HashMap<>() {{

I will fix this locally so you don't need to fix it here - but if you submit more PRs, can you ensure that they compile?

Sorry, my fault. I'll definitely check it next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants