Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment variable injection for SOAP and WSDL endpoints #55

Merged
merged 56 commits into from
Sep 25, 2022
Merged

Add environment variable injection for SOAP and WSDL endpoints #55

merged 56 commits into from
Sep 25, 2022

Conversation

n-jay
Copy link
Member

@n-jay n-jay commented Feb 13, 2022 •
edited
Loading

Purpose

Add environment variable injection capability to SOAP and WSDL endpoints.

Approach

Amended AddressEndpointFactory & WSDLEndpointFactory classes to extract environment variables via System.getenv() based on $SYSTEM prefix presence in the Synapse config XML uri elements.

Automation Tests

  • Unit tests
    Covers code written in AddressEndpointFactory.

  • Integration tests
    N/A

Test environment

  • Java version 1.8.0_141
  • Ubuntu 20.04

Learning

A medium post describing the context of the project is linked here.
@n-jay
Add environment variable resolvers for SOAP services
a85a439
@n-jay
Add environment variable resolvers for WSDL services
d725f3f
@n-jay
Add log outputs for when env. variables are resolved
5cf128f
@n-jay
Add junit dependencies to pom
502ecd0
@n-jay
Add unit test for env. variable injection
a12b66c 
In SOAP endpoints
@n-jay
Add maven central repo to repositories list
3688230
@n-jay
Add SystemProperties to pom.xml
8b20738
@n-jay
Enable preliminary unit test for parameter injection
dd47b7c
@n-jay
Merge branch 'master' of https://github.com/n-jay/synapse into feature1
ee30758
@n-jay
Merge branch 'feature1' of https://github.com/n-jay/synapse into feat…
4d86278 
…ure1
@n-jay
Add systemProperties values
cf914b1 
This is to unit test environment variable extraction during build time.
@n-jay
Add environment variable extraction testing library
a988bee
@n-jay
Add system-rules library in Synapse core module pom
684ed55
@n-jay
Remove newly added unneeded dependencies from root pom
a0fb33d
@n-jay
Add exception to log malformed variable injections
e51b2b4
@n-jay
Add unit test to verify parameter injection for SOAP endpoints
6869b86
@n-jay
Add System-rules library to root pom
68d3f81 
Used to mock environment variable injection setting during build-time
@n-jay
Remove code changes with unnecessary libraries
0ceb0be
@n-jay
Add environment variables parameter
94c85d5 
Delete external library inclusions & add environment variables via surefire
@n-jay
Remove assertion code
af70c05 
Code to be verified in PR
@n-jay
Add Environment Variable field
3d28045 
To check unit tests during build time
@n-jay
Add unit tests for WSDL endpoint parameter injection
736bd24
@n-jay
Add environment variable parameters for use in WSDL endpoint unit tests
40f9b7e
@n-jay
Remove redundant unit test
bc220e7
@n-jay
Add unit test for validating Address Endpoint variable injection
d7e0f77
@n-jay
Update environment variables in pom
5242e2b
n-jay
n-jay commented Apr 25, 2022
View reviewed changes
modules/core/src/main/java/org/apache/synapse/config/xml/endpoints/AddressEndpointFactory.java Outdated
extractedEnvVariableValue);
endpointDefinition.setAddress(extractedEnvVariableValue);
} else {
endpointDefinition.setAddress(extractedAddress);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the no. of variables and remove the else condition
Copy link
Member Author

@n-jay n-jay May 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit: 8e51818
@n-jay
Copy link
Member Author

n-jay commented Apr 25, 2022 •
edited
Loading

Code review conducted. Changes requested:

  • Add system prefix constant to SynapseConstants file.
  • Add singular method to DefaultEndpointFactory and call it from the extended class
n-jay added 19 commits May 9, 2022 00:50
@n-jay
Comment out buggy unit test
3f6ec59 
Pending correction upon code review
@n-jay
Reset previous line changes
da9a5d1 
Amended line changes to earlier state in EndpointFactories
@n-jay
Remove unnecessary dependency
2980b59
@n-jay
Remove redundant method
e573f64
@n-jay
Add new class with variable injection method
382d86c
@n-jay
Update WSDL methods to include parameter injection
467b7ae
@n-jay
Update ConfigUtils class
1b2abe7 
Rename method and make it static
@n-jay
Update WSDLEndpoint to accomodate static fetchEnvironmentVariables me…
8ef353e 
…thod
@n-jay
Add variable injection and address retrieval to SOAP endpoint definition
98674a5
@n-jay
Update serializer and test with new address retrieval method
7667908
@n-jay
Remove buggy log.debug line
84fa3b1
@n-jay
Enable SOAP endpoint parameter injection unit tests
3a3d9cc
@n-jay
Update WSDL endpoint serializer with new method
d316006 
New method used for retrieving RAW parameters for serialization
@n-jay
Update with getters for injected parameter values
209d4a2
@n-jay
Add new parameter injection and retrieval
2ea572f
@n-jay
Enable WSDL endpoint parameter injection unit tests
40a9973
@n-jay
Merge branch 'master' into feature1
e2b1981
@n-jay
Add missing override @ annotation
2b1e226
@n-jay
Merge remote-tracking branch 'origin/feature1' into feature1
404b2c8
isudana
isudana requested changes Sep 25, 2022
View reviewed changes
modules/core/src/main/java/org/apache/synapse/config/xml/endpoints/AddressEndpointFactory.java Outdated Show resolved Hide resolved
modules/core/src/main/java/org/apache/synapse/config/xml/endpoints/utils/ConfigUtils.java Outdated Show resolved Hide resolved
modules/core/src/main/java/org/apache/synapse/endpoints/EndpointDefinition.java Outdated Show resolved Hide resolved
modules/core/src/main/java/org/apache/synapse/endpoints/WSDLEndpoint.java Outdated Show resolved Hide resolved
modules/core/src/main/java/org/apache/synapse/endpoints/WSDLEndpoint.java Show resolved Hide resolved
modules/core/src/main/java/org/apache/synapse/endpoints/WSDLEndpoint.java Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
modules/core/pom.xml Show resolved Hide resolved
modules/core/src/main/java/org/apache/synapse/config/xml/endpoints/AddressEndpointFactory.java Show resolved Hide resolved
@isudana isudana merged commit e81d26d into apache:master Sep 25, 2022
@n-jay n-jay mentioned this pull request Feb 16, 2023
Merged
@n-jay n-jay mentioned this pull request Mar 3, 2023
Merged
@n-jay n-jay mentioned this pull request Mar 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@n-jay @isudana