-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curl settings break many shared hosts #614
Comments
I've committed a partial fix for this. Need to test. |
It should be noted that there needs to be a similar fix applied to the mention client code. I'm wondering whether forking this to use the native webservices library might be smart... |
Refs: indieweb/mention-client-php#15 (requires) Refs: idno#629 Refs: idno#614
My 0.02$: I encountered the same issues in a recent project. Basically, AFAIK, the only way to mitigate such an issue is to write a custom wrapper to follow redirections (but there may be security risks). Note: In PHP 5.6.3, warning is no longer issued if open_basedir is set and CURL_FOLLOWLOCATION is used. That is still the case in PHP 5.4.35. |
It's a bit more subtle.... The known web services code does exactly that, however a number of third party modules use their own comms code (curl or otherwise) and so need to be modified to use known's web service code. For mentions this requires a modification in the upstream project, however I'm starting to think we should fork the project. |
True, I forgot about the external dependencies… mentions is the only external dependency that requires some modification, no ? Because for all the others, you seem not to be using the function |
Refs: indieweb/mention-client-php#15 (requires) Refs: idno#629 Refs: idno#614
This hasn't come up again since last year, so I'm closing the issue. |
This error has been coming up a lot:
"CURLOPT_FOLLOWLOCATION cannot be activated when an open_basedir is set"
We need to test if open_basedir is set before setting this option.
The text was updated successfully, but these errors were encountered: