Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-syntax-3] Fix serialization matrix related to CDC-token #6874

Merged
merged 1 commit into from
Dec 9, 2021
Merged

[css-syntax-3] Fix serialization matrix related to CDC-token #6874

merged 1 commit into from
Dec 9, 2021

Conversation

lahmatiy
Copy link
Contributor

@lahmatiy lahmatiy commented Dec 9, 2021

Since double dash -- is a valid identifier by the spec the CDC-token is breaking "round-trip" with parsing now when follows after #, -, number or @:

  • #--> = #-- (hash-token) + > (delim-token)
  • ---> = --- (ident-token) + > (delim-token)
  • number--> = number-- (dimension-token) + > (delim-token)
  • @--> = @-- (at-keyword-token) + > (delim-token)
Since double dash `--` is a valid identifier by the spec the `CDC-token` is breaking "round-trip" with parsing now when follows after `#`, `-`, number or `@`:
* `#-->` = `#--` (hash-token) + `>` (delim-token)
* `--->` = `---` (ident-token) + `>` (delim-token)
* `number-->` = `number--` (dimension-token) + `>` (delim-token)
* `@-->` = `@--` (at-keyword-token) + `>` (delim-token)
@w3cbot
Copy link

w3cbot commented Dec 9, 2021

lahmatiy marked as non substantive for IPR from ash-nazg.

@tabatkins tabatkins merged commit 09b0869 into w3c:main Dec 9, 2021
@tabatkins
Copy link
Member

Oooh good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment