#21954 closed theme (not-approved)
THEME: HappenStance - 1.0.1
| Reported by: |
tomastoman
|
Owned by: |
chellycat
|
|---|---|---|---|
| Priority: | new theme | Keywords: | theme-happenstance |
| Cc: | webdesign@… |
Description
HappenStance - 1.0.0
HappenStance is an easily customizable theme which can be used for your Blog, Magazine, Business, eCommerce or Events website. It is a fully responsive and Retina ready theme that allows for easy viewing on any device. HappenStance theme offers 4 pre-defined color schemes, 220 Google fonts, Theme Options panel for easy adaptation to your needs, selection between Boxed or Wide layout, 2 blog layouts (One Column and Grid - Masonry), contact information in header, ability to set your header logo and favicon, sidebar and footer widget areas, theme documentation and much more. Supports the popular plugins WooCommerce, The Events Calendar and Breadcrumb NavXT. Available in Czech, English, French, German, Russian, Slovak and Spanish.
Theme URL - http://www.tomastoman.cz/happenstance/
Author URL - http://www.tomastoman.cz/
SVN - https://themes.svn.wordpress.org/happenstance/1.0.0
ZIP - https://wordpress.org/themes/download/happenstance.1.0.0.zip?nostats=1
History:
Change History (8)
@
#3
@
10 years ago
Howdy! My name is Michelle and I'll be reviewing your theme. :) Expect initial notes from me within the next few days.
#4
@
10 years ago
Dear Michelle,
thank you for reviewing this theme! I am looking forward to your notes, hopefully there won't be too much issues in the theme. :-)
Best regards,
Tomas Toman
#5
@
10 years ago
- Resolution set to not-approved
- Status changed from reviewing to closed
Hi @tomastoman,
I did a quick initial review, and it's looking good so far. I didn't see too many issues. Here are my notes:
BLOCKER:
- Please remove Appearance > Install Plugins, as well as the “Begin Installing Plugins” link from the plugins admin notice. This is not allowed.
UNIT TEST / VISUAL (These are all suggestions)
- Increase line height for site title and tagline. When they are on multiple lines, it looks squished: https://cloudup.com/cuHeBJ-3U65
- Add padding to the footer so that the footer notices widget area doesn’t bump against the top of the container (https://cloudup.com/cJPXEN6J4bX). Checking “automatically add paragraphs” in the widget moves the text down, but IMO it should look “right” even if the box isn’t checked.
- 404 page mentions “perhaps searching will help you find a related page” — what do you think about adding a search box below this? This is only a suggestion.
NEXT:
After you fix the one blocker above and upload a new version, I'll do a more in-depth review of the theme's options, code and settings. So far I'm not seeing major issues. :)
#6
@
10 years ago
Dear Michelle,
thank you for your initial review! I would have one question about your blocker note. There are many themes in the repository which recommend installing some plugins (for example the Responsive theme). So far I thought that it only isn't allowed to install plugins which are directly bundled into the theme, but if they are installed from the wordpress.org plugins repository, it is allowed to attach them using the TGM-Plugin-Activation (like I did). Have the guidelines been recently changed please? I see no problem in removing the "Install Plugins" panel, I just wanted to make sure. :-)
Best regards,
Tomas Toman
#7
@
10 years ago
It's fine to have the admin notice for recommended plugins, but the separate "Install Plugins" page and menu item are not allowed as per the guidelines. Themes aren't allowed to install or add anything to the Dashboard except for a Theme Options page.
Just linking to the plugins on the .org repository inside the admin notice is sufficient.
I hope this helps!
Cheers,
Michelle
HappenStance - 1.0.1
HappenStance is an easily customizable theme which can be used for your Blog, Magazine, Business, eCommerce or Events website. It is a fully responsive and Retina ready theme that allows for easy viewing on any device. HappenStance theme offers 4 pre-defined color schemes, 220 Google fonts, Theme Options panel for easy adaptation to your needs, selection between Boxed or Wide layout, 2 blog layouts (One Column and Grid - Masonry), contact information in header, ability to set your header logo and favicon, sidebar and footer widget areas, theme documentation and much more. Supports the popular plugins WooCommerce, The Events Calendar and Breadcrumb NavXT. Available in Czech, English, French, German, Russian, Slovak and Spanish.
Theme URL - http://www.tomastoman.cz/happenstance/
Author URL - http://www.tomastoman.cz/
SVN - https://themes.svn.wordpress.org/happenstance/1.0.1
ZIP - https://wordpress.org/themes/download/happenstance.1.0.1.zip?nostats=1
Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/happenstance/1.0.0&new_path=/happenstance/1.0.1
History:
(this ticket)